netdev - Re: [PATCH] at86rf230: convert to gpio descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <f83ae34a-b46a-47c8-817a-d82d43178eba@app.fastmail.com>
Date:   Thu, 26 Jan 2023 15:39:45 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Miquel Raynal" <miquel.raynal@...tlin.com>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     "Alexander Aring" <alex.aring@...il.com>,
        "Stefan Schmidt" <stefan@...enfreihafen.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Paolo Abeni" <pabeni@...hat.com>,
        "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        linux-wpan@...r.kernel.org, Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] at86rf230: convert to gpio descriptors

On Thu, Jan 26, 2023, at 15:12, Miquel Raynal wrote:

>> @@ -1682,7 +1650,7 @@ MODULE_DEVICE_TABLE(spi, at86rf230_device_id);
>>  static struct spi_driver at86rf230_driver = {
>>  	.id_table = at86rf230_device_id,
>>  	.driver = {
>> -		.of_match_table = of_match_ptr(at86rf230_of_match),
>> +		.of_match_table = at86rf230_of_match,
>
> Looks like an unrelated change? Or is it a consequence of "not having
> any in-tree users of platform_data" that plays a role here?

I probably did it because I thought I had removed the matching #ifdef
for at86rf230_of_match in the process of making the driver DT-only.

Without this trivial change, building the driver as built-in with
CONFIG_OF=n can result in a warning like

drivers/net/ieee802154/at86rf230.c:1632:28: error: unused variable 'at86rf230_of_match' [-Werror,-Wunused-variable]

It looks like this was already removed in a8b66db804f0 ("at86rf230:
remove #ifdef CONFIG_OF"), which was not technically correct, but
nobody noticed, including me.

I could split this out as a separate patch, but it's probably
not worth it.

> Anyhow, the changes in the driver look good, so:
>
> Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>

Thanks,

    Arnd