Date:   Thu, 26 Jan 2023 08:25:03 -0800
From:   Suren Baghdasaryan <surenb@...gle.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Mike Rapoport <rppt@...nel.org>, akpm@...ux-foundation.org,
        michel@...pinasse.org, jglisse@...gle.com, mhocko@...e.com,
        vbabka@...e.cz, hannes@...xchg.org, mgorman@...hsingularity.net,
        dave@...olabs.net, liam.howlett@...cle.com, peterz@...radead.org,
        ldufour@...ux.ibm.com, paulmck@...nel.org, luto@...nel.org,
        songliubraving@...com, peterx@...hat.com, david@...hat.com,
        dhowells@...hat.com, hughd@...gle.com, bigeasy@...utronix.de,
        kent.overstreet@...ux.dev, punit.agrawal@...edance.com,
        lstoakes@...il.com, peterjung1337@...il.com, rientjes@...gle.com,
        axelrasmussen@...gle.com, joelaf@...gle.com, minchan@...gle.com,
        jannh@...gle.com, shakeelb@...gle.com, tatashin@...gle.com,
        edumazet@...gle.com, gthelen@...gle.com, gurua@...gle.com,
        arjunroy@...gle.com, soheil@...gle.com, hughlynch@...gle.com,
        leewalsh@...gle.com, posk@...gle.com, will@...nel.org,
        aneesh.kumar@...ux.ibm.com, npiggin@...il.com,
        chenhuacai@...nel.org, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, dave.hansen@...ux.intel.com, richard@....at,
        anton.ivanov@...bridgegreys.com, johannes@...solutions.net,
        qianweili@...wei.com, wangzhou1@...ilicon.com,
        herbert@...dor.apana.org.au, davem@...emloft.net, vkoul@...nel.org,
        airlied@...il.com, daniel@...ll.ch,
        maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
        tzimmermann@...e.de, l.stach@...gutronix.de,
        krzysztof.kozlowski@...aro.org, patrik.r.jakobsson@...il.com,
        matthias.bgg@...il.com, robdclark@...il.com,
        quic_abhinavk@...cinc.com, dmitry.baryshkov@...aro.org,
        tomba@...nel.org, hjc@...k-chips.com, heiko@...ech.de,
        ray.huang@....com, kraxel@...hat.com, sre@...nel.org,
        mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com,
        tfiga@...omium.org, m.szyprowski@...sung.com, mchehab@...nel.org,
        dimitri.sivanich@....com, zhangfei.gao@...aro.org,
        jejb@...ux.ibm.com, martin.petersen@...cle.com,
        dgilbert@...erlog.com, hdegoede@...hat.com, mst@...hat.com,
        jasowang@...hat.com, alex.williamson@...hat.com, deller@....de,
        jayalk@...works.biz, viro@...iv.linux.org.uk, nico@...xnic.net,
        xiang@...nel.org, chao@...nel.org, tytso@....edu,
        adilger.kernel@...ger.ca, miklos@...redi.hu,
        mike.kravetz@...cle.com, muchun.song@...ux.dev, bhe@...hat.com,
        andrii@...nel.org, yoshfuji@...ux-ipv6.org, dsahern@...nel.org,
        kuba@...nel.org, pabeni@...hat.com, perex@...ex.cz, tiwai@...e.com,
        haojian.zhuang@...il.com, robert.jarzmik@...e.fr,
        linux-mm@...ck.org, linux-arm-kernel@...ts.infradead.org,
        linuxppc-dev@...ts.ozlabs.org, x86@...nel.org,
        linux-kernel@...r.kernel.org, linux-graphics-maintainer@...are.com,
        linux-ia64@...r.kernel.org, linux-arch@...r.kernel.org,
        loongarch@...ts.linux.dev, kvm@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-sgx@...r.kernel.org,
        linux-um@...ts.infradead.org, linux-acpi@...r.kernel.org,
        linux-crypto@...r.kernel.org, nvdimm@...ts.linux.dev,
        dmaengine@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, etnaviv@...ts.freedesktop.org,
        linux-samsung-soc@...r.kernel.org, intel-gfx@...ts.freedesktop.org,
        linux-mediatek@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
        freedreno@...ts.freedesktop.org,
        linux-rockchip@...ts.infradead.org, linux-tegra@...r.kernel.org,
        virtualization@...ts.linux-foundation.org,
        xen-devel@...ts.xenproject.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-rdma@...r.kernel.org, linux-media@...r.kernel.org,
        linux-accelerators@...ts.ozlabs.org, sparclinux@...r.kernel.org,
        linux-scsi@...r.kernel.org, linux-staging@...ts.linux.dev,
        target-devel@...r.kernel.org, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org, linux-fbdev@...r.kernel.org,
        linux-aio@...ck.org, linux-fsdevel@...r.kernel.org,
        linux-erofs@...ts.ozlabs.org, linux-ext4@...r.kernel.org,
        devel@...ts.orangefs.org, kexec@...ts.infradead.org,
        linux-xfs@...r.kernel.org, bpf@...r.kernel.org,
        linux-perf-users@...r.kernel.org, kasan-dev@...glegroups.com,
        selinux@...r.kernel.org, alsa-devel@...a-project.org,
        kernel-team@...roid.com
Subject: Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions

On Thu, Jan 26, 2023 at 7:09 AM Matthew Wilcox <willy@...radead.org> wrote:
>
> On Thu, Jan 26, 2023 at 04:50:59PM +0200, Mike Rapoport wrote:
> > On Thu, Jan 26, 2023 at 11:17:09AM +0200, Mike Rapoport wrote:
> > > On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote:
> > > > +/* Use when VMA is not part of the VMA tree and needs no locking */
> > > > +static inline void init_vm_flags(struct vm_area_struct *vma,
> > > > +                          unsigned long flags)
> > >
> > > I'd suggest to make it vm_flags_init() etc.
> >
> > Thinking more about it, it will be even clearer to name these vma_flags_xyz()
>
> Perhaps vma_VERB_flags()?
>
> vma_init_flags()
> vma_reset_flags()
> vma_set_flags()
> vma_clear_flags()
> vma_mod_flags()

Due to excessive email bouncing I posted the v3 of this patchset using
the original per-VMA patchset's distribution list. That might have
dropped Mike from the list. Sorry about that Mike, I'll add you to my
usual list of suspects :)
The v3 is here:
https://lore.kernel.org/all/20230125233554.153109-1-surenb@google.com/
and Andrew did suggest the same renames, so I'll be posting v4 with
those changes later today.
Thanks for the feedback!

>

Powered by blists - more mailing lists