netdev - Re: [PATCH net 2/2] net/mlx5e: xsk: Set napi_id to support busy polling on XSK RQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Jan 2023 22:43:02 +0200
From:   Tariq Toukan <ttoukan.linux@...il.com>
To:     Maxim Mikityanskiy <maxtram95@...il.com>, netdev@...r.kernel.org,
        Saeed Mahameed <saeedm@...dia.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Gal Pressman <gal@...dia.com>,
        Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH net 2/2] net/mlx5e: xsk: Set napi_id to support busy
 polling on XSK RQ



On 26/01/2023 21:10, Maxim Mikityanskiy wrote:
> The cited commit missed setting napi_id on XSK RQs, it only affected
> regular RQs. Add the missing part to support socket busy polling on XSK
> RQs.
> 
> Fixes: a2740f529da2 ("net/mlx5e: xsk: Set napi_id to support busy polling")
> Signed-off-by: Maxim Mikityanskiy <maxtram95@...il.com>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c
> index ff03c43833bb..53c93d1daa7e 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c
> @@ -71,7 +71,7 @@ static int mlx5e_init_xsk_rq(struct mlx5e_channel *c,
>   	if (err)
>   		return err;
>   
> -	return  xdp_rxq_info_reg(&rq->xdp_rxq, rq->netdev, rq_xdp_ix, 0);
> +	return xdp_rxq_info_reg(&rq->xdp_rxq, rq->netdev, rq_xdp_ix, c->napi.napi_id);
>   }
>   
>   static int mlx5e_open_xsk_rq(struct mlx5e_channel *c, struct mlx5e_params *params,

Reviewed-by: Tariq Toukan <tariqt@...dia.com>
Thanks for your patch!