netdev - Re: [PATCH net] sfc: correctly advertise tunneled IPv6 segmentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9I/RmuOPJeHJ8X1@gmail.com>
Date:   Thu, 26 Jan 2023 08:52:22 +0000
From:   Martin Habets <habetsm.xilinx@...il.com>
To:     Íñigo Huguet <ihuguet@...hat.com>
Cc:     ecree.xilinx@...il.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
        Tianhao Zhao <tizhao@...hat.com>
Subject: Re: [PATCH net] sfc: correctly advertise tunneled IPv6 segmentation

On Wed, Jan 25, 2023 at 03:35:13PM +0100, Íñigo Huguet wrote:
> Recent sfc NICs are TSO capable for some tunnel protocols. However, it
> was not working properly because the feature was not advertised in
> hw_enc_features, but in hw_features only.
> 
> Setting up a GENEVE tunnel and using iperf3 to send IPv4 and IPv6 traffic
> to the tunnel show, with tcpdump, that the IPv4 packets still had ~64k
> size but the IPv6 ones had only ~1500 bytes (they had been segmented by
> software, not offloaded). With this patch segmentation is offloaded as
> expected and the traffic is correctly received at the other end.
> 
> Fixes: 24b2c3751aa3 ("sfc: advertise encapsulated offloads on EF10")
> Reported-by: Tianhao Zhao <tizhao@...hat.com>
> Signed-off-by: Íñigo Huguet <ihuguet@...hat.com>

Acked-by: Martin Habets <habetsm.xilinx@...il.com>

> ---
>  drivers/net/ethernet/sfc/efx.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
> index 0556542d7a6b..3a86f1213a05 100644
> --- a/drivers/net/ethernet/sfc/efx.c
> +++ b/drivers/net/ethernet/sfc/efx.c
> @@ -1003,8 +1003,11 @@ static int efx_pci_probe_post_io(struct efx_nic *efx)
>  	/* Determine netdevice features */
>  	net_dev->features |= (efx->type->offload_features | NETIF_F_SG |
>  			      NETIF_F_TSO | NETIF_F_RXCSUM | NETIF_F_RXALL);
> -	if (efx->type->offload_features & (NETIF_F_IPV6_CSUM | NETIF_F_HW_CSUM))
> +	if (efx->type->offload_features & (NETIF_F_IPV6_CSUM | NETIF_F_HW_CSUM)) {
>  		net_dev->features |= NETIF_F_TSO6;
> +		if (efx_has_cap(efx, TX_TSO_V2_ENCAP))
> +			net_dev->hw_enc_features |= NETIF_F_TSO6;
> +	}
>  	/* Check whether device supports TSO */
>  	if (!efx->type->tso_versions || !efx->type->tso_versions(efx))
>  		net_dev->features &= ~NETIF_F_ALL_TSO;
> -- 
> 2.34.3