[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y9Ovcc5jkiEVz0XC@gmail.com>
Date: Fri, 27 Jan 2023 11:03:13 +0000
From: Martin Habets <habetsm.xilinx@...il.com>
To: alejandro.lucero-palau@....com
Cc: netdev@...r.kernel.org, linux-net-drivers@....com,
davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
edumazet@...gle.com, ecree.xilinx@...il.com
Subject: Re: [PATCH v3 net-next 0/8] sfc: devlink support for ef100
On Fri, Jan 27, 2023 at 09:36:43AM +0000, alejandro.lucero-palau@....com wrote:
> From: Alejandro Lucero <alejandro.lucero-palau@....com>
>
> v3 changes:
> - fix compilation warnings/errors reported by checkpatch
I hope you also fixed the modpost issue reported in
https://lore.kernel.org/netdev/202301251924.Vt4cZmeM-lkp@intel.com/
>
> v2 changes:
> - splitting up devlink info from basic devlink support
> - using devlink lock/unlock during initialization and removal
> - fix devlink registration order
> - splitting up efx_devlink_info_running_versions
> - Add sfc.rst with specifics about sfc info
> - embedding dl_port in mports
> - using extack for error reports to user space
>
> This patchset adds devlink port support for ef100 allowing setting VFs
> mac addresses through the VF representor devlink ports.
>
> Basic devlink infrastructure is first introduced, then support for info
> command. Next changes for enumerating MAE ports which will be used for
> devlik port creation when netdevs are registered.
Typo: devlik should be devlink.
>
> Adding support for devlink port_function_hw_addr_get requires changes in
> the ef100 driver for getting the mac address based on a client handle.
> This allows to obtain VFs mac address during netdev initialization as
> well what is included in patch 6.
>
> Such client handle is used in patches 7 and 8 for getting and setting
> devlink ports addresses.
port in stead of ports.
Martin
>
> Alejandro Lucero (8):
> sfc: add devlink support for ef100
> sfc: add devlink info support for ef100
> sfc: enumerate mports in ef100
> sfc: add mport lookup based on driver's mport data
> sfc: add devlink port support for ef100
> sfc: obtain device mac address based on firmware handle for ef100
> sfc: add support for devlink port_function_hw_addr_get in ef100
> sfc: add support for devlink port_function_hw_addr_set in ef100
>
> Documentation/networking/devlink/sfc.rst | 57 ++
> drivers/net/ethernet/sfc/Kconfig | 1 +
> drivers/net/ethernet/sfc/Makefile | 3 +-
> drivers/net/ethernet/sfc/ef100_netdev.c | 31 ++
> drivers/net/ethernet/sfc/ef100_nic.c | 93 +++-
> drivers/net/ethernet/sfc/ef100_nic.h | 7 +
> drivers/net/ethernet/sfc/ef100_rep.c | 57 +-
> drivers/net/ethernet/sfc/ef100_rep.h | 10 +
> drivers/net/ethernet/sfc/efx_devlink.c | 660 +++++++++++++++++++++++
> drivers/net/ethernet/sfc/efx_devlink.h | 46 ++
> drivers/net/ethernet/sfc/mae.c | 218 +++++++-
> drivers/net/ethernet/sfc/mae.h | 41 ++
> drivers/net/ethernet/sfc/mcdi.c | 72 +++
> drivers/net/ethernet/sfc/mcdi.h | 8 +
> drivers/net/ethernet/sfc/net_driver.h | 8 +
> 15 files changed, 1285 insertions(+), 27 deletions(-)
> create mode 100644 Documentation/networking/devlink/sfc.rst
> create mode 100644 drivers/net/ethernet/sfc/efx_devlink.c
> create mode 100644 drivers/net/ethernet/sfc/efx_devlink.h
>
> --
> 2.17.1
Powered by blists - more mailing lists