netdev - Re: [patch net-next v2 09/12] devlink: protect devlink param list by instance lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9O4UUzxI1HAjVq1@corigine.com>
Date:   Fri, 27 Jan 2023 12:41:05 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, edumazet@...gle.com, michael.chan@...adcom.com,
        jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
        tariqt@...dia.com, saeedm@...dia.com, leon@...nel.org,
        idosch@...dia.com, petrm@...dia.com, aelior@...vell.com,
        manishc@...vell.com, jacob.e.keller@...el.com, gal@...dia.com,
        yinjun.zhang@...igine.com, fei.qin@...igine.com,
        Niklas.Cassel@....com
Subject: Re: [patch net-next v2 09/12] devlink: protect devlink param list by
 instance lock

On Fri, Jan 27, 2023 at 12:32:21PM +0100, Simon Horman wrote:
> On Thu, Jan 26, 2023 at 08:58:35AM +0100, Jiri Pirko wrote:
> > From: Jiri Pirko <jiri@...dia.com>
> > 
> > Commit 1d18bb1a4ddd ("devlink: allow registering parameters after
> > the instance") as the subject implies introduced possibility to register
> > devlink params even for already registered devlink instance. This is a
> > bit problematic, as the consistency or params list was originally
> > secured by the fact it is static during devlink lifetime. So in order to
> > protect the params list, take devlink instance lock during the params
> > operations. Introduce unlocked function variants and use them in drivers
> > in locked context. Put lock assertions to appropriate places.
> > 
> > Signed-off-by: Jiri Pirko <jiri@...dia.com>
> > Reviewed-by: Jakub Kicinski <kuba@...nel.org>
> > Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> > ---
> >  drivers/net/ethernet/mellanox/mlx4/main.c     | 80 ++++++++--------
> >  drivers/net/ethernet/mellanox/mlx5/core/dev.c | 18 ++--
> >  .../net/ethernet/mellanox/mlx5/core/devlink.c | 92 +++++++++----------
> >  drivers/net/ethernet/mellanox/mlx5/core/eq.c  | 12 +--
> >  .../net/ethernet/mellanox/mlx5/core/eswitch.c |  6 +-
> >  .../net/ethernet/mellanox/mlx5/core/main.c    | 12 +--
> >  drivers/net/ethernet/mellanox/mlxsw/core.c    | 18 ++--
> >  .../net/ethernet/mellanox/mlxsw/spectrum.c    | 16 ++--
> >  .../ethernet/netronome/nfp/devlink_param.c    |  8 +-
> >  .../net/ethernet/netronome/nfp/nfp_net_main.c |  7 +-
> >  drivers/net/netdevsim/dev.c                   | 36 ++++----
> >  include/net/devlink.h                         | 16 +++-
> >  net/devlink/leftover.c                        | 77 +++++++++++-----
> >  13 files changed, 218 insertions(+), 180 deletions(-)
> 
> For the nfp portion:
> 
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> 
> I will also see about getting the patchset tested on NFP hardware.

Seems the team was a bit further ahead on the testing than I thought.
So, on their behalf:

Tested-by: Simon Horman <simon.horman@...igine.com>