netdev - Re: [PATCH net-next 08/11] net: add missing includes of linux/splice.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7b971e79-f301-e2fb-7cfe-1a3062ccc0f5@linux.ibm.com>
Date:   Fri, 27 Jan 2023 13:35:06 +0100
From:   Wenjia Zhang <wenjia@...ux.ibm.com>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
        kgraul@...ux.ibm.com, jaka@...ux.ibm.com, kuniyu@...zon.com,
        linux-s390@...r.kernel.org
Subject: Re: [PATCH net-next 08/11] net: add missing includes of
 linux/splice.h



On 26.01.23 08:14, Jakub Kicinski wrote:
> Number of files depend on linux/splice.h getting included
> by linux/skbuff.h which soon will no longer be the case.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: kgraul@...ux.ibm.com
> CC: wenjia@...ux.ibm.com
> CC: jaka@...ux.ibm.com
> CC: kuniyu@...zon.com
> CC: linux-s390@...r.kernel.org
> ---
>   net/smc/af_smc.c   | 1 +
>   net/smc/smc_rx.c   | 1 +
>   net/unix/af_unix.c | 1 +
>   3 files changed, 3 insertions(+)
> 
> diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
> index 036532cf39aa..1c0fe9ba5358 100644
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -27,6 +27,7 @@
>   #include <linux/if_vlan.h>
>   #include <linux/rcupdate_wait.h>
>   #include <linux/ctype.h>
> +#include <linux/splice.h>
>   
>   #include <net/sock.h>
>   #include <net/tcp.h>
> diff --git a/net/smc/smc_rx.c b/net/smc/smc_rx.c
> index 0a6e615f000c..4380d32f5a5f 100644
> --- a/net/smc/smc_rx.c
> +++ b/net/smc/smc_rx.c
> @@ -13,6 +13,7 @@
>   #include <linux/net.h>
>   #include <linux/rcupdate.h>
>   #include <linux/sched/signal.h>
> +#include <linux/splice.h>
>   

Thank you, Jakub!
Acked-by: Wenjia Zhang <wenjia@...ux.ibm.com>

>   #include <net/sock.h>
>   #include <trace/events/sock.h>
> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
> index 009616fa0256..0be25e712c28 100644
> --- a/net/unix/af_unix.c
> +++ b/net/unix/af_unix.c
> @@ -112,6 +112,7 @@
>   #include <linux/mount.h>
>   #include <net/checksum.h>
>   #include <linux/security.h>
> +#include <linux/splice.h>
>   #include <linux/freezer.h>
>   #include <linux/file.h>
>   #include <linux/btf_ids.h>