netdev - Re: [PATCH v1 net] net: phy: fix null dereference in phy_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d2e6c03-7351-1c8e-4fa7-51794a9164bd@gmail.com>
Date:   Fri, 27 Jan 2023 09:32:30 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Colin Foster <colin.foster@...advantage.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Cc:     Xiaolei Wang <xiaolei.wang@...driver.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Russell King <linux@...linux.org.uk>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v1 net] net: phy: fix null dereference in
 phy_attach_direct



On 1/27/2023 9:14 AM, Colin Foster wrote:
> Commit bc66fa87d4fd ("net: phy: Add link between phy dev and mac dev")
> introduced a link between net devices and phy devices. It fails to check
> whether dev is NULL, leading to a NULL dereference error.
> 
> Fixes: bc66fa87d4fd ("net: phy: Add link between phy dev and mac dev")
> Signed-off-by: Colin Foster <colin.foster@...advantage.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian