netdev - Re: [PATCH net-next] sh: checksum: add missing linux/uaccess.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9VKZhCOdM4L28UA@corigine.com>
Date:   Sat, 28 Jan 2023 17:16:38 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, ysato@...rs.sourceforge.jp, dalias@...c.org,
        linux-sh@...r.kernel.org
Subject: Re: [PATCH net-next] sh: checksum: add missing linux/uaccess.h
 include

On Fri, Jan 27, 2023 at 11:31:08PM -0800, Jakub Kicinski wrote:
> SuperH does not include uaccess.h, even tho it calls access_ok().

I see that is true.
But it's less clear to me why that is a problem.

> Fixes: 68f4eae781dd ("net: checksum: drop the linux/uaccess.h include")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: ysato@...rs.sourceforge.jp
> CC: dalias@...c.org
> CC: linux-sh@...r.kernel.org
> ---
>  arch/sh/include/asm/checksum_32.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/sh/include/asm/checksum_32.h b/arch/sh/include/asm/checksum_32.h
> index a6501b856f3e..2b5fa75b4651 100644
> --- a/arch/sh/include/asm/checksum_32.h
> +++ b/arch/sh/include/asm/checksum_32.h
> @@ -7,6 +7,7 @@
>   */
>  
>  #include <linux/in6.h>
> +#include <linux/uaccess.h>
>  
>  /*
>   * computes the checksum of a memory block at buff, length len,
> -- 
> 2.39.1
>