netdev - Re: [PATCH net-next] sh: checksum: add missing linux/uaccess.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9V963IQhnL9ieLk@corigine.com>
Date:   Sat, 28 Jan 2023 20:56:27 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, ysato@...rs.sourceforge.jp, dalias@...c.org,
        linux-sh@...r.kernel.org
Subject: Re: [PATCH net-next] sh: checksum: add missing linux/uaccess.h
 include

On Sat, Jan 28, 2023 at 05:29:37PM +0100, Simon Horman wrote:
> On Sat, Jan 28, 2023 at 05:16:48PM +0100, Simon Horman wrote:
> > On Fri, Jan 27, 2023 at 11:31:08PM -0800, Jakub Kicinski wrote:
> > > SuperH does not include uaccess.h, even tho it calls access_ok().
> > 
> > I see that is true.
> > But it's less clear to me why that is a problem.
> 
> Ok, now I see the kernel test robot splat.
> Let me try and reproduce it for my own edification.

Done. Unsurprisingly, your patch resolves the problem.

Reviewed-by: Simon Horman <simon.horman@...igine.com>
Tested-by: Simon Horman <simon.horman@...igine.com>

For the record, the splat is here:
- https://lore.kernel.org/netdev/202301281438.ZNGVwW6S-lkp@intel.com/