netdev - Re: [PATCH] net: dsa: microchip: ptp: add one more PTP dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <2d90460c-9d30-46cb-871e-e2500243ffd3@app.fastmail.com>
Date:   Sat, 28 Jan 2023 22:44:22 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Richard Cochran" <richardcochran@...il.com>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     "Woojung Huh" <woojung.huh@...rochip.com>,
        UNGLinuxDriver@...rochip.com, "Andrew Lunn" <andrew@...n.ch>,
        "Florian Fainelli" <f.fainelli@...il.com>,
        "Vladimir Oltean" <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Paolo Abeni" <pabeni@...hat.com>,
        "Arun Ramadoss" <arun.ramadoss@...rochip.com>,
        "Jacob Keller" <jacob.e.keller@...el.com>,
        Netdev <netdev@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: microchip: ptp: add one more PTP dependency

On Sat, Jan 28, 2023, at 00:58, Richard Cochran wrote:
> On Fri, Jan 27, 2023 at 11:13:03PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> When only NET_DSA_MICROCHIP_KSZ8863_SMI is built-in but
>> PTP is a loadable module, the ksz_ptp support still causes
>> a link failure:
>> 
>> ld.lld-16: error: undefined symbol: ptp_clock_index
>> >>> referenced by ksz_ptp.c
>> >>>               drivers/net/dsa/microchip/ksz_ptp.o:(ksz_get_ts_info) in archive vmlinux.a
>> 
>> Add the same dependency here that exists with the KSZ9477_I2C
>> and KSZ_SPI drivers.
>> 
>> Fixes: eac1ea20261e ("net: dsa: microchip: ptp: add the posix clock support")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Acked-by: Richard Cochran <richardcochran@...il.com>

The randconfig builder just found another regression in the same
driver, I'll have to send a new version, so please disregard this one
for now.

      Arnd