netdev - Re: [PATCH] xfrm: fix bug with DSCP copy to v6 from v4 tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9R9TBekaAzQZu6S@gondor.apana.org.au>
Date:   Sat, 28 Jan 2023 09:41:32 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Christian Hopps <chopps@...n.net>
Cc:     Steffen Klassert <steffen.klassert@...unet.com>,
        "David S. Miller" <davem@...emloft.net>, devel@...ux-ipsec.org,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        chopps@...pps.org
Subject: Re: [PATCH] xfrm: fix bug with DSCP copy to v6 from v4 tunnel

On Fri, Jan 27, 2023 at 07:31:54AM -0500, Christian Hopps wrote:
>
> Yes that's what the immediate git blame points at; however, that code was copied from net/ipv6/xfrm6_mode_tunnel.c:xfrm6_tunnel_input() and that code arrived in:
> 
>    b59f45d0b2878 ("[IPSEC] xfrm: Abstract out encapsulation modes")
> 
> Originally this code using a different sk_buff layout was from the initial git repo checkin.
> 
>    1da177e4c3f41 ("Linux-2.6.12-rc2")
> 
> Why don't I just remove the fixes line? I didn't want to include it initially anyway.

On closer inspection my patch was definitely buggy in that it would
place some random value in the DSCP field.  Previously the code
simply didn't copy the TOS value across.

Steffen, keeping the Fixes header is fine by me.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt