netdev - Re: [PATCH net v2 0/5] net: xdp: execute xdp_do_flush() before napi_complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167488801911.1883.7455001304854457036.git-patchwork-notify@kernel.org>
Date:   Sat, 28 Jan 2023 06:40:19 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Magnus Karlsson <magnus.karlsson@...il.com>
Cc:     magnus.karlsson@...el.com, bjorn@...nel.org, ast@...nel.org,
        daniel@...earbox.net, netdev@...r.kernel.org,
        jonathan.lemon@...il.com, maciej.fijalkowski@...el.com,
        kuba@...nel.org, toke@...hat.com, pabeni@...hat.com,
        davem@...emloft.net, aelior@...vell.com, manishc@...vell.com,
        horatiu.vultur@...rochip.com, UNGLinuxDriver@...rochip.com,
        mst@...hat.com, jasowang@...hat.com, ioana.ciornei@....com,
        madalin.bucur@....com, bpf@...r.kernel.org
Subject: Re: [PATCH net v2 0/5] net: xdp: execute xdp_do_flush() before
 napi_complete_done()

Hello:

This series was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 25 Jan 2023 08:48:56 +0100 you wrote:
> Make sure that xdp_do_flush() is always executed before
> napi_complete_done(). This is important for two reasons. First, a
> redirect to an XSKMAP assumes that a call to xdp_do_redirect() from
> napi context X on CPU Y will be followed by a xdp_do_flush() from the
> same napi context and CPU. This is not guaranteed if the
> napi_complete_done() is executed before xdp_do_flush(), as it tells
> the napi logic that it is fine to schedule napi context X on another
> CPU. Details from a production system triggering this bug using the
> veth driver can be found in [1].
> 
> [...]

Here is the summary with links:
  - [net,v2,1/5] qede: execute xdp_do_flush() before napi_complete_done()
    https://git.kernel.org/netdev/net/c/2ccce20d51fa
  - [net,v2,2/5] lan966x: execute xdp_do_flush() before napi_complete_done()
    https://git.kernel.org/netdev/net/c/12b5717990c8
  - [net,v2,3/5] virtio-net: execute xdp_do_flush() before napi_complete_done()
    https://git.kernel.org/netdev/net/c/ad7e615f646c
  - [net,v2,4/5] dpaa_eth: execute xdp_do_flush() before napi_complete_done()
    https://git.kernel.org/netdev/net/c/b534013798b7
  - [net,v2,5/5] dpaa2-eth: execute xdp_do_flush() before napi_complete_done()
    https://git.kernel.org/netdev/net/c/a3191c4d86c5

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html