netdev - Re: [RFC PATCH net-next 07/15] net/sched: taprio: rename close_time to end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 28 Jan 2023 13:05:29 +0100
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     Vinicius Costa Gomes <vinicius.gomes@...el.com>
Subject: Re: [RFC PATCH net-next 07/15] net/sched: taprio: rename close_time
 to end_time

On Sat Jan 28 2023, Vladimir Oltean wrote:
> There is a confusion in terms in taprio which makes what is called
> "close_time" to be actually used for 2 things:
>
> 1. determining when an entry "closes" such that transmitted skbs are
>    never allowed to overrun that time (?!)
> 2. an aid for determining when to advance and/or restart the schedule
>    using the hrtimer
>
> It makes more sense to call this so-called "close_time" "end_time",
> because it's not clear at all to me what "closes". Future patches will
> hopefully make better use of the term "to close".
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Kurt Kanzenbach <kurt@...utronix.de>

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)