[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y9Zb+RU637gLIwgz@unreal>
Date: Sun, 29 Jan 2023 13:43:53 +0200
From: Leon Romanovsky <leon@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Vladimir Oltean <olteanv@...il.com>,
"David S . Miller" <davem@...emloft.net>,
Andrew Lunn <andrew@...n.ch>,
bridge@...ts.linux-foundation.org,
Eric Dumazet <edumazet@...gle.com>,
Florian Fainelli <f.fainelli@...il.com>,
netdev@...r.kernel.org, Nikolay Aleksandrov <razor@...ckwall.org>,
Paolo Abeni <pabeni@...hat.com>,
Roopa Prabhu <roopa@...dia.com>
Subject: Re: [PATCH net-next] netlink: provide an ability to set default
extack message
On Thu, Jan 26, 2023 at 11:26:15PM -0800, Jakub Kicinski wrote:
> On Fri, 27 Jan 2023 07:26:13 +0200 Leon Romanovsky wrote:
> > > That'd be my preference too, FWIW. It's only the offload cases which
> > > need this sort of fallback.
> >
> > Of course not, almost any error unwind path which sets extack will need it.
>
> I guess we can come up with scenarios where the new behavior would
> be useful. But the fact is - your patch changes 4 places...
ok, I'll rename.
>
> > See devlink as an example
>
> I don't know what part of devlink you mean at a quick scroll.
I overlooked "return err" in the middle.
You are right.
Thanks
Powered by blists - more mailing lists