netdev - Re: [PATCH net] sctp: do not check hb_timer.expires when resetting hb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9fxI5Ai5/1J8LFh@t14s.localdomain>
Date:   Mon, 30 Jan 2023 13:32:35 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        davem@...emloft.net, kuba@...nel.org,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Neil Horman <nhorman@...driver.com>
Subject: Re: [PATCH net] sctp: do not check hb_timer.expires when resetting
 hb_timer

On Mon, Jan 30, 2023 at 11:25:33AM -0500, Xin Long wrote:
> It tries to avoid the frequently hb_timer refresh in commit ba6f5e33bdbb
> ("sctp: avoid refreshing heartbeat timer too often"), and it only allows
> mod_timer when the new expires is after hb_timer.expires. It means even
> a much shorter interval for hb timer gets applied, it will have to wait
> until the current hb timer to time out.
> 
> In sctp_do_8_2_transport_strike(), when a transport enters PF state, it
> expects to update the hb timer to resend a heartbeat every rto after
> calling sctp_transport_reset_hb_timer(), which will not work as the
> change mentioned above.
> 
> The frequently hb_timer refresh was caused by sctp_transport_reset_timers()
> called in sctp_outq_flush() and it was already removed in the commit above.
> So we don't have to check hb_timer.expires when resetting hb_timer as it is
> now not called very often.
> 
> Fixes: ba6f5e33bdbb ("sctp: avoid refreshing heartbeat timer too often")
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>