netdev - Re: [PATCH net-next v2] neighbor: fix proxy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <78b84d51-b758-8e1b-f2f9-8c844b8a25d2@gmail.com>
Date:   Mon, 30 Jan 2023 12:13:48 -0500
From:   Brian Haley <haleyb.dev@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] neighbor: fix proxy_delay usage when it is
 zero

On 1/27/23 2:37 AM, Jakub Kicinski wrote:
> On Wed, 25 Jan 2023 14:51:14 -0500 Brian Haley wrote:
>> +	or proxy_ndp is enabled. A random value between [0, proxy_delay]
> 
> Do you mean: [0, proxy_delay) or there's something that can give us an
> extra jiffy (IOW shouldn't the upper limit be open) ?
> 
> it's
>    random() % MAX - (1 - noise)
> 
> where (1 - noise) is the fraction of jiffy which already passed since
> the tick.
> 
> Sorry if I'm slow to get it..

Yes, it's [0, proxy_delay), should have just copied that right from the 
get_random_u32_below() definition. I'll send a v3 fixing the commit 
message and sysctl doc.

-Brian