netdev - [PATCH] wifi: nl80211: log for malformed chandef

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20230130074514.1560021-1-jaewan@google.com>
Date:   Mon, 30 Jan 2023 07:45:14 +0000
From:   Jaewan Kim <jaewan@...gle.com>
To:     johannes@...solutions.net, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org
Cc:     kernel-team@...roid.com, Jaewan Kim <jaewan@...gle.com>
Subject: [PATCH] wifi: nl80211: log for malformed chandef

This change ensures consistency for returning error in
nl80211_parse_chandef() by logging reasons for all EINVAL returns.

Signed-off-by: Jaewan Kim <jaewan@...gle.com>
---
 net/wireless/nl80211.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 33a82ecab9d5..e12b01721bec 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -3181,8 +3181,11 @@ int nl80211_parse_chandef(struct cfg80211_registered_device *rdev,
 	struct nlattr **attrs = info->attrs;
 	u32 control_freq;
 
-	if (!attrs[NL80211_ATTR_WIPHY_FREQ])
+	if (!attrs[NL80211_ATTR_WIPHY_FREQ]) {
+		NL_SET_ERR_MSG_ATTR(extack, attrs[NL80211_ATTR_WIPHY_FREQ],
+				    "Frequency is missing");
 		return -EINVAL;
+	}
 
 	control_freq = MHZ_TO_KHZ(
 			nla_get_u32(info->attrs[NL80211_ATTR_WIPHY_FREQ]));
-- 
2.39.1.456.gfc5497dd1b-goog