netdev - Re: [PATCH net v4 1/2] ice: Prevent set_channel from changing queues while RDMA active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9eJ6TasOLEK/LYO@unreal>
Date:   Mon, 30 Jan 2023 11:12:09 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, Dave Ertman <david.m.ertman@...el.com>,
        netdev@...r.kernel.org, Gurucharan G <gurucharanx.g@...el.com>
Subject: Re: [PATCH net v4 1/2] ice: Prevent set_channel from changing queues
 while RDMA active

On Fri, Jan 27, 2023 at 02:53:32PM -0800, Tony Nguyen wrote:
> From: Dave Ertman <david.m.ertman@...el.com>
> 
> The PF controls the set of queues that the RDMA auxiliary_driver requests
> resources from.  The set_channel command will alter that pool and trigger a
> reconfiguration of the VSI, which breaks RDMA functionality.
> 
> Prevent set_channel from executing when RDMA driver bound to auxiliary
> device.
> 
> Adding a locked variable to pass down the call chain to avoid double
> locking the device_lock.
> 
> Fixes: 348048e724a0 ("ice: Implement iidc operations")
> Signed-off-by: Dave Ertman <david.m.ertman@...el.com>
> Tested-by: Gurucharan G <gurucharanx.g@...el.com> (A Contingent worker at Intel)
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice.h         |  2 +-
>  drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 23 +++++++++-------
>  drivers/net/ethernet/intel/ice/ice_dcb_lib.h |  4 +--
>  drivers/net/ethernet/intel/ice/ice_ethtool.c | 28 +++++++++++++++++---
>  drivers/net/ethernet/intel/ice/ice_main.c    |  5 ++--
>  5 files changed, 43 insertions(+), 19 deletions(-)

Honestly, it looks horrid to see holding two locks and "locked"
parameter just to send an event to AUX driver.

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>