netdev - RE: [PATCH net] net: fman: memac: free mdio device if lynx_pcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR04MB3976C49C0FE000A571DA6CA7ECD09@AM6PR04MB3976.eurprd04.prod.outlook.com>
Date:   Tue, 31 Jan 2023 07:54:51 +0000
From:   "Madalin Bucur (OSS)" <madalin.bucur@....nxp.com>
To:     Vladimir Oltean <vladimir.oltean@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Sean Anderson <sean.anderson@...o.com>,
        Camelia Alexandra Groza <camelia.groza@....com>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: RE: [PATCH net] net: fman: memac: free mdio device if
 lynx_pcs_create() fails

> -----Original Message-----
> From: Vladimir Oltean <vladimir.oltean@....com>
> To: netdev@...r.kernel.org
> Cc: Madalin Bucur <madalin.bucur@....com>; David S. Miller
> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski
> <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Sean Anderson
> <sean.anderson@...o.com>; Camelia Alexandra Groza <camelia.groza@....com>;
> Maxime Chevallier <maxime.chevallier@...tlin.com>
> Subject: [PATCH net] net: fman: memac: free mdio device if
> lynx_pcs_create() fails
> 
> When memory allocation fails in lynx_pcs_create() and it returns NULL,
> there remains a dangling reference to the mdiodev returned by
> of_mdio_find_device() which is leaked as soon as memac_pcs_create()
> returns empty-handed.
> 
> Fixes: a7c2a32e7f22 ("net: fman: memac: Use lynx pcs driver")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
>  drivers/net/ethernet/freescale/fman/fman_memac.c | 3 +++
>  1 file changed, 3 insertions(+)

Acked-by: Madalin Bucur <madalin.bucur@....nxp.com>