[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y9jQpjLPkRR/emeH@unreal>
Date: Tue, 31 Jan 2023 10:26:14 +0200
From: Leon Romanovsky <leon@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
edumazet@...gle.com, netdev@...r.kernel.org, bhelgaas@...gle.com
Subject: Re: [PATCH net-next 0/8][pull request] Intel Wired LAN: Remove
redundant Device Control Error Reporting Enable
On Mon, Jan 30, 2023 at 11:25:11AM -0800, Tony Nguyen wrote:
> Bjorn Helgaas says:
>
> Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"),
> the PCI core sets the Device Control bits that enable error reporting for
> PCIe devices.
>
> This series removes redundant calls to pci_enable_pcie_error_reporting()
> that do the same thing from several NIC drivers.
>
> There are several more drivers where this should be removed; I started with
> just the Intel drivers here.
> ---
> TN: Removed mention of AER driver as this was taken through PCI tree [1]
> and fixed a typo.
>
> [1] https://lore.kernel.org/all/20230126231527.GA1322015@bhelgaas/
>
> The following are changes since commit 90e8ca0abb05ada6c1e2710eaa21688dafca26f2:
> Merge branch 'devlink-next'
> and are available in the git repository at:
> git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue 10GbE
>
> Bjorn Helgaas (8):
> e1000e: Remove redundant pci_enable_pcie_error_reporting()
> fm10k: Remove redundant pci_enable_pcie_error_reporting()
> i40e: Remove redundant pci_enable_pcie_error_reporting()
> iavf: Remove redundant pci_enable_pcie_error_reporting()
> ice: Remove redundant pci_enable_pcie_error_reporting()
> igb: Remove redundant pci_enable_pcie_error_reporting()
> igc: Remove redundant pci_enable_pcie_error_reporting()
> ixgbe: Remove redundant pci_enable_pcie_error_reporting()
>
> drivers/net/ethernet/intel/e1000e/netdev.c | 7 -------
> drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 5 -----
> drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ----
> drivers/net/ethernet/intel/iavf/iavf_main.c | 5 -----
> drivers/net/ethernet/intel/ice/ice_main.c | 3 ---
> drivers/net/ethernet/intel/igb/igb_main.c | 5 -----
> drivers/net/ethernet/intel/igc/igc_main.c | 5 -----
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 -----
> 8 files changed, 39 deletions(-)
I see that you didn't touch any other places except drivers/net/ethernet/intel/.
Are you planning to remove other occurrences too?
➜ kernel git:(rdma-next) git grep pci_enable_pcie_error_reporting -- drivers/infiniband/
drivers/infiniband/hw/hfi1/pcie.c: (void)pci_enable_pcie_error_reporting(pdev);
drivers/infiniband/hw/qib/qib_pcie.c: ret = pci_enable_pcie_error_reporting(pdev);
Thanks
>
> --
> 2.38.1
>
Powered by blists - more mailing lists