| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <3f73311f-fe96-9c57-1a7f-920d46b03541@amd.com>
Date: Tue, 31 Jan 2023 09:40:22 +0000
From: "Lucero Palau, Alejandro" <alejandro.lucero-palau@....com>
To: "Lucero Palau, Alejandro" <alejandro.lucero-palau@....com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-net-drivers (AMD-Xilinx)" <linux-net-drivers@....com>,
"davem@...emloft.net" <davem@...emloft.net>,
"kuba@...nel.org" <kuba@...nel.org>,
"pabeni@...hat.com" <pabeni@...hat.com>,
"edumazet@...gle.com" <edumazet@...gle.com>,
"ecree.xilinx@...il.com" <ecree.xilinx@...il.com>
Subject: Re: [PATCH v3 net-next 7/8] sfc: add support for devlink
port_function_hw_addr_get in ef100
On 1/27/23 11:51, Martin Habets wrote:
> On Fri, Jan 27, 2023 at 09:36:50AM +0000, alejandro.lucero-palau@....com wrote:
>> From: Alejandro Lucero <alejandro.lucero-palau@....com>
>>
>> Using the builtin client handle id infrastructure, this patch adds
>> support for obtaining the mac address linked to mports in ef100. This
>> implies to execute an MCDI command for getting the data from the
>> firmware for each devlink port.
>>
>> Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@....com>
>> ---
>> drivers/net/ethernet/sfc/ef100_nic.c | 27 ++++++++++++++++
>> drivers/net/ethernet/sfc/ef100_nic.h | 1 +
>> drivers/net/ethernet/sfc/ef100_rep.c | 8 +++++
>> drivers/net/ethernet/sfc/ef100_rep.h | 1 +
>> drivers/net/ethernet/sfc/efx_devlink.c | 44 ++++++++++++++++++++++++++
>> 5 files changed, 81 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/sfc/ef100_nic.c b/drivers/net/ethernet/sfc/ef100_nic.c
>> index bcf937fb3d95..e64a7fb5353b 100644
>> --- a/drivers/net/ethernet/sfc/ef100_nic.c
>> +++ b/drivers/net/ethernet/sfc/ef100_nic.c
>> @@ -1121,6 +1121,33 @@ static int ef100_probe_main(struct efx_nic *efx)
>> return rc;
>> }
>>
>> +/* MCDI commands are related to the same device issuing them. This function
>> + * allows to do an MCDI command on behalf of another device, mainly PFs setting
>> + * things for VFs.
>> + */
>> +int efx_ef100_lookup_client_id(struct efx_nic *efx, efx_qword_t pciefn, u32 *id)
>> +{
>> + MCDI_DECLARE_BUF(outbuf, MC_CMD_GET_CLIENT_HANDLE_OUT_LEN);
>> + MCDI_DECLARE_BUF(inbuf, MC_CMD_GET_CLIENT_HANDLE_IN_LEN);
>> + u64 pciefn_flat = le64_to_cpu(pciefn.u64[0]);
>> + size_t outlen;
>> + int rc;
>> +
>> + MCDI_SET_DWORD(inbuf, GET_CLIENT_HANDLE_IN_TYPE,
>> + MC_CMD_GET_CLIENT_HANDLE_IN_TYPE_FUNC);
>> + MCDI_SET_QWORD(inbuf, GET_CLIENT_HANDLE_IN_FUNC,
>> + pciefn_flat);
>> +
>> + rc = efx_mcdi_rpc(efx, MC_CMD_GET_CLIENT_HANDLE, inbuf, sizeof(inbuf),
>> + outbuf, sizeof(outbuf), &outlen);
>> + if (rc)
>> + return rc;
>> + if (outlen < sizeof(outbuf))
>> + return -EIO;
>> + *id = MCDI_DWORD(outbuf, GET_CLIENT_HANDLE_OUT_HANDLE);
>> + return 0;
>> +}
>> +
>> int ef100_probe_netdev_pf(struct efx_nic *efx)
>> {
>> struct ef100_nic_data *nic_data = efx->nic_data;
>> diff --git a/drivers/net/ethernet/sfc/ef100_nic.h b/drivers/net/ethernet/sfc/ef100_nic.h
>> index e59044072333..f1ed481c1260 100644
>> --- a/drivers/net/ethernet/sfc/ef100_nic.h
>> +++ b/drivers/net/ethernet/sfc/ef100_nic.h
>> @@ -94,4 +94,5 @@ int ef100_filter_table_probe(struct efx_nic *efx);
>>
>> int ef100_get_mac_address(struct efx_nic *efx, u8 *mac_address,
>> int client_handle, bool empty_ok);
>> +int efx_ef100_lookup_client_id(struct efx_nic *efx, efx_qword_t pciefn, u32 *id);
>> #endif /* EFX_EF100_NIC_H */
>> diff --git a/drivers/net/ethernet/sfc/ef100_rep.c b/drivers/net/ethernet/sfc/ef100_rep.c
>> index 6b5bc5d6955d..0b3083ef0ead 100644
>> --- a/drivers/net/ethernet/sfc/ef100_rep.c
>> +++ b/drivers/net/ethernet/sfc/ef100_rep.c
>> @@ -361,6 +361,14 @@ bool ef100_mport_on_local_intf(struct efx_nic *efx,
>> mport_desc->interface_idx == nic_data->local_mae_intf;
>> }
>>
>> +bool ef100_mport_is_vf(struct mae_mport_desc *mport_desc)
>> +{
>> + bool pcie_func;
>> +
>> + pcie_func = ef100_mport_is_pcie_vnic(mport_desc);
>> + return pcie_func && (mport_desc->vf_idx != MAE_MPORT_DESC_VF_IDX_NULL);
>> +}
>> +
>> void efx_ef100_init_reps(struct efx_nic *efx)
>> {
>> struct ef100_nic_data *nic_data = efx->nic_data;
>> diff --git a/drivers/net/ethernet/sfc/ef100_rep.h b/drivers/net/ethernet/sfc/ef100_rep.h
>> index ae6add4b0855..a042525a2240 100644
>> --- a/drivers/net/ethernet/sfc/ef100_rep.h
>> +++ b/drivers/net/ethernet/sfc/ef100_rep.h
>> @@ -76,4 +76,5 @@ void efx_ef100_fini_reps(struct efx_nic *efx);
>> struct mae_mport_desc;
>> bool ef100_mport_on_local_intf(struct efx_nic *efx,
>> struct mae_mport_desc *mport_desc);
>> +bool ef100_mport_is_vf(struct mae_mport_desc *mport_desc);
>> #endif /* EF100_REP_H */
>> diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
>> index b1637eb372ad..2c84e89bd007 100644
>> --- a/drivers/net/ethernet/sfc/efx_devlink.c
>> +++ b/drivers/net/ethernet/sfc/efx_devlink.c
>> @@ -58,6 +58,49 @@ static int efx_devlink_add_port(struct efx_nic *efx,
>> return devl_port_register(efx->devlink, &mport->dl_port, mport->mport_id);
>> }
>>
>> +static int efx_devlink_port_addr_get(struct devlink_port *port, u8 *hw_addr,
>> + int *hw_addr_len,
>> + struct netlink_ext_ack *extack)
>> +{
>> + struct efx_devlink *devlink = devlink_priv(port->devlink);
>> + struct mae_mport_desc *mport_desc;
>> + efx_qword_t pciefn;
>> + u32 client_id;
>> + int rc = 0;
>> +
>> + mport_desc = container_of(port, struct mae_mport_desc, dl_port);
>> +
>> + if (!ef100_mport_on_local_intf(devlink->efx, mport_desc)) {
>> + rc = -EINVAL;
>> + NL_SET_ERR_MSG_MOD(extack, "Port not on local interface");
> Since we're giving this addional info we should at least provide the
> mport_id to help us diagnose the issue.
Well, I guess it does not make any harm, but note if that is the case,
it is something inherently wrong we should have detected earlier, not
just when user space uses it.
I'll add it anyway.
>> + goto out;
>> + }
>> +
>> + if (ef100_mport_is_vf(mport_desc))
>> + EFX_POPULATE_QWORD_3(pciefn,
>> + PCIE_FUNCTION_PF, PCIE_FUNCTION_PF_NULL,
>> + PCIE_FUNCTION_VF, mport_desc->vf_idx,
>> + PCIE_FUNCTION_INTF, PCIE_INTERFACE_CALLER);
>> + else
>> + EFX_POPULATE_QWORD_3(pciefn,
>> + PCIE_FUNCTION_PF, mport_desc->pf_idx,
>> + PCIE_FUNCTION_VF, PCIE_FUNCTION_VF_NULL,
>> + PCIE_FUNCTION_INTF, PCIE_INTERFACE_CALLER);
>> +
>> + rc = efx_ef100_lookup_client_id(devlink->efx, pciefn, &client_id);
>> + if (rc) {
>> + NL_SET_ERR_MSG_MOD(extack, "No internal client_ID for port");
>> + goto out;
>> + }
>> +
>> + rc = ef100_get_mac_address(devlink->efx, hw_addr, client_id, true);
>> + if (rc != 0)
>> + NL_SET_ERR_MSG_MOD(extack, "No available MAC for port");
> Same.
>
> Martin
>
>> +out:
>> + *hw_addr_len = ETH_ALEN;
>> + return rc;
>> +}
>> +
>> static int efx_devlink_info_nvram_partition(struct efx_nic *efx,
>> struct devlink_info_req *req,
>> unsigned int partition_type,
>> @@ -463,6 +506,7 @@ static int efx_devlink_info_get(struct devlink *devlink,
>>
>> static const struct devlink_ops sfc_devlink_ops = {
>> .info_get = efx_devlink_info_get,
>> + .port_function_hw_addr_get = efx_devlink_port_addr_get,
>> };
>>
>> static struct devlink_port *ef100_set_devlink_port(struct efx_nic *efx, u32 idx)
>> --
>> 2.17.1
Powered by blists - more mailing lists