[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <801a4a44f0fb6e37f79037eae9a3db50191cdb12.camel@redhat.com>
Date: Tue, 31 Jan 2023 12:47:03 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Leon Romanovsky <leon@...nel.org>,
"David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>, bridge@...ts.linux-foundation.org,
Eric Dumazet <edumazet@...gle.com>,
Florian Fainelli <f.fainelli@...il.com>,
Herbert Xu <herbert@...dor.apana.org.au>,
netdev@...r.kernel.org, Nikolay Aleksandrov <razor@...ckwall.org>,
Roopa Prabhu <roopa@...dia.com>,
Steffen Klassert <steffen.klassert@...unet.com>,
Vladimir Oltean <olteanv@...il.com>
Subject: Re: [PATCH net-next v2] netlink: provide an ability to set default
extack message
Hello,
On Sun, 2023-01-29 at 18:51 +0200, Leon Romanovsky wrote:
> In netdev common pattern, extack pointer is forwarded to the drivers
> to be filled with error message. However, the caller can easily
> overwrite the filled message.
>
> Instead of adding multiple "if (!extack->_msg)" checks before any
> NL_SET_ERR_MSG() call, which appears after call to the driver, let's
> add new macro to common code.
>
> [1] https://lore.kernel.org/all/Y9Irgrgf3uxOjwUm@unreal
> Signed-off-by: Leon Romanovsky <leonro@...dia.com>
I'm sorry for nit-picking, but checkpatch complains the author
(leon@...nel.org) does not match the SoB tag. A v3 with a suitable
From: tag should fix that.
Thanks,
Paolo
Powered by blists - more mailing lists