[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y9kYnnYRMW9Vi0DU@lunn.ch>
Date: Tue, 31 Jan 2023 14:33:18 +0100
From: Andrew Lunn <andrew@...n.ch>
To: "Frank.Sae" <Frank.Sae@...or-comm.com>
Cc: Rob Herring <robh@...nel.org>, Peter Geis <pgwipeout@...il.com>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
yanhong.wang@...rfivetech.com, xiaogang.fan@...or-comm.com,
fei.zhang@...or-comm.com, hua.sun@...or-comm.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v3 1/5] dt-bindings: net: Add Motorcomm yt8xxx
ethernet phy
> phy id list:
> YT8511 0x0000010a
> YT8521 0x0000011A
> YT8531 0x4f51e91b
The first two are clearly invalid, the OUI part is zero. So i would
not list those. Just use the last one.
In the binding part, you need something like
properties:
compatible:
const: ethernet-phy-id4f51.e91b
description: Only needed for DT lint tools
What i don't know is how this will work in combination with the
compatibles gained from ethernet-phy.yaml. You might need to follow
the same structure, include a oneOf:
In the example part, you would do something like:
>
> mdio0 {
> ...
> ethernet-phy@5 {
# Only needed to make DT lint tools work. Do not copy/paste
# into real DTS files.
> compatible = "ethernet-phy-id4f51.e91b";
> reg = <5>;
> ...
> };
> };
I don't think there are any examples to follow because the kernel
does not need any of this, is probes using the IDs. Listing
compatibles like this is purely for the DT tools, which is why i put
in the comments about not copy/pasting it to real DT blobs.
Andrew
Powered by blists - more mailing lists