[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y9koUno9kGkNJkma@qwirkle>
Date: Tue, 31 Jan 2023 14:40:18 +0000
From: Andrei Gherzan <andrei.gherzan@...onical.com>
To: Willem de Bruijn <willemb@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>,
netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/4] selftests: net: udpgso_bench_rx/tx: Stop when
wrong CLI args are provided
On 23/01/31 08:35AM, Willem de Bruijn wrote:
> On Tue, Jan 31, 2023 at 8:08 AM Andrei Gherzan
> <andrei.gherzan@...onical.com> wrote:
> >
> > Leaving unrecognized arguments buried in the output, can easily hide a
> > CLI/script typo. Avoid this by exiting when wrong arguments are provided to
> > the udpgso_bench test programs.
> >
> > Signed-off-by: Andrei Gherzan <andrei.gherzan@...onical.com>
>
> I'm on the fence on this. Test binaries are not necessarily robust
> against bad input. If you insist.
I'll keep it in the set (for next v), but I don't mind if it doesn't end
up applied. It was just something I stumbled into.
> When sending patches to net, please always add a Fixes tag.
I'll keep that in mind.
--
Andrei Gherzan
Powered by blists - more mailing lists