[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAFXsbZpUdfkxxnH3Ex5BUmvnxJYP-4wQ2Ai7Wrvf-O7KaPF-aw@mail.gmail.com>
Date: Tue, 31 Jan 2023 13:07:03 -0800
From: Chris Healy <cphealy@...il.com>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>,
Russell King - ARM Linux <linux@...linux.org.uk>,
David Miller <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Eric Dumazet <edumazet@...gle.com>,
Neil Armstrong <neil.armstrong@...aro.org>,
Kevin Hilman <khilman@...libre.com>,
Jerome Brunet <jbrunet@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"open list:ARM/Amlogic Meson..." <linux-amlogic@...ts.infradead.org>
Subject: Re: [PATCH net] net: phy: meson-gxl: use MMD access dummy stubs for
GXL, internal PHY
Reviewed-by: Chris Healy <healych@...zon.com>
On Tue, Jan 31, 2023 at 1:03 PM Heiner Kallweit <hkallweit1@...il.com> wrote:
>
> Jerome provided the information that also the GXL internal PHY doesn't
> support MMD register access and EEE. MMD reads return 0xffff, what
> results in e.g. completely wrong ethtool --show-eee output.
> Therefore use the MMD dummy stubs.
>
> Note: The Fixes tag references the commit that added the MMD dummy
> access stubs.
>
> Fixes: 5df7af85ecd8 ("net: phy: Add general dummy stubs for MMD register access")
> Suggested-by: Jerome Brunet <jbrunet@...libre.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
> drivers/net/phy/meson-gxl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
> index c49062ad7..fbf5f2416 100644
> --- a/drivers/net/phy/meson-gxl.c
> +++ b/drivers/net/phy/meson-gxl.c
> @@ -261,6 +261,8 @@ static struct phy_driver meson_gxl_phy[] = {
> .handle_interrupt = meson_gxl_handle_interrupt,
> .suspend = genphy_suspend,
> .resume = genphy_resume,
> + .read_mmd = genphy_read_mmd_unsupported,
> + .write_mmd = genphy_write_mmd_unsupported,
> }, {
> PHY_ID_MATCH_EXACT(0x01803301),
> .name = "Meson G12A Internal PHY",
> --
> 2.39.1
>
Powered by blists - more mailing lists