[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+FuTSfeehkZMZonHA-nFDK37=eNdG6E-7xkcixn1Hs_s44_EQ@mail.gmail.com>
Date: Tue, 31 Jan 2023 16:47:13 -0500
From: Willem de Bruijn <willemb@...gle.com>
To: Andrei Gherzan <andrei.gherzan@...onical.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>,
Fred Klassen <fklassen@...neta.com>, netdev@...r.kernel.org,
linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 4/4] selftests: net: udpgso_bench_tx: Cater
for pending datagrams zerocopy benchmarking
On Tue, Jan 31, 2023 at 4:01 PM Andrei Gherzan
<andrei.gherzan@...onical.com> wrote:
>
> The test tool can check that the zerocopy number of completions value is
> valid taking into consideration the number of datagram send calls. This can
> catch the system into a state where the datagrams are still in the system
> (for example in a qdisk, waiting for the network interface to return a
> completion notification, etc).
>
> This change adds a retry logic of computing the number of completions up to
> a configurable (via CLI) timeout (default: 2 seconds).
>
> Fixes: 79ebc3c26010 ("net/udpgso_bench_tx: options to exercise TX CMSG")
> Signed-off-by: Andrei Gherzan <andrei.gherzan@...onical.com>
> Cc: Willem de Bruijn <willemb@...gle.com>
> Cc: Paolo Abeni <pabeni@...hat.com>
Fixes should go to net, instead of net-next.
But the code itself looks good to me.
Reviewed-by: Willem de Bruijn <willemb@...gle.com>
Powered by blists - more mailing lists