[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CA+FuTSdLWYbAU2iXg7e1hJSZTKapAELSKRVB+m=krm_hUL9vLw@mail.gmail.com>
Date: Tue, 31 Jan 2023 16:53:24 -0500
From: Willem de Bruijn <willemb@...gle.com>
To: Andrei Gherzan <andrei.gherzan@...onical.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>,
netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 3/4] selftests: net: udpgso_bench: Fix racing
bug between the rx/tx programs
On Tue, Jan 31, 2023 at 3:56 PM Andrei Gherzan
<andrei.gherzan@...onical.com> wrote:
>
> "udpgro_bench.sh" invokes udpgso_bench_rx/udpgso_bench_tx programs
> subsequently and while doing so, there is a chance that the rx one is not
> ready to accept socket connections. This racing bug could fail the test
> with at least one of the following:
>
> ./udpgso_bench_tx: connect: Connection refused
> ./udpgso_bench_tx: sendmsg: Connection refused
> ./udpgso_bench_tx: write: Connection refused
>
> This change addresses this by making udpgro_bench.sh wait for the rx
> program to be ready before firing off the tx one - up to a 10s timeout.
>
> Fixes: 3a687bef148d ("selftests: udp gso benchmark")
> Signed-off-by: Andrei Gherzan <andrei.gherzan@...onical.com>
> CC: Paolo Abeni <pabeni@...hat.com>
> CC: Willem de Bruijn <willemb@...gle.com>
Same point on fixes to net instead of net-next.
Aside from that, looks good. Neat solution. Thanks for the suggestion, Paolo.
Reviewed-by: Willem de Bruijn <willemb@...gle.com>
Powered by blists - more mailing lists