netdev - [PATCH net v4 0/2] mlx5: ptp fifo bugfixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230201122605.1350664-1-vadfed@meta.com>
Date:   Wed, 1 Feb 2023 04:26:03 -0800
From:   Vadim Fedorenko <vadfed@...a.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
        Rahul Rameshbabu <rrameshbabu@...dia.com>,
        "Tariq Toukan" <ttoukan.linux@...il.com>,
        Gal Pressman <gal@...dia.com>,
        "Saeed Mahameed" <saeed@...nel.org>
CC:     Vadim Fedorenko <vadfed@...a.com>, <netdev@...r.kernel.org>
Subject: [PATCH net v4 0/2] mlx5: ptp fifo bugfixes

Simple FIFO implementation for PTP queue has several bugs which lead to
use-after-free and skb leaks. This series fixes the issues and adds new
checks for this FIFO implementation to uncover the same problems in
future.

v3 -> v4:
  Change pr_err to mlx5_core_err_rl per suggest
	Removed WARN_ONCE on fifo push because has_room() should catch the
	issue
v2 -> v3:
  Rearrange patches order and rephrase commit messages
  Remove counters as Gal confirmed FW bug, use KERN_ERR message instead
  Provide proper budget to napi_consume_skb as Jakub suggested
v1 -> v2:
  Update Fixes tag to proper commit.
  Change debug line to avoid double print of function name

Vadim Fedorenko (2):
  mlx5: fix skb leak while fifo resync and push
  mlx5: fix possible ptp queue fifo use-after-free

 .../net/ethernet/mellanox/mlx5/core/en/ptp.c  | 25 ++++++++++++++-----
 .../net/ethernet/mellanox/mlx5/core/en/txrx.h |  6 +++--
 2 files changed, 23 insertions(+), 8 deletions(-)

-- 
2.30.2