netdev - Re: [PATCH net] net: phy: meson-gxl: use MMD access dummy stubs for GXL, internal PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9pfBpoZ4cezf6Bb@pek-khao-d2>
Date:   Wed, 1 Feb 2023 20:45:58 +0800
From:   Kevin Hao <haokexin@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        David Miller <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "open list:ARM/Amlogic Meson..." <linux-amlogic@...ts.infradead.org>,
        Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH net] net: phy: meson-gxl: use MMD access dummy stubs for
 GXL, internal PHY

On Tue, Jan 31, 2023 at 09:55:28PM -0800, Jakub Kicinski wrote:
> On Tue, 31 Jan 2023 22:03:21 +0100 Heiner Kallweit wrote:
> > Jerome provided the information that also the GXL internal PHY doesn't
> > support MMD register access and EEE. MMD reads return 0xffff, what
> > results in e.g. completely wrong ethtool --show-eee output.
> > Therefore use the MMD dummy stubs.
> > 
> > Note: The Fixes tag references the commit that added the MMD dummy
> > access stubs.
> > 
> > Fixes: 5df7af85ecd8 ("net: phy: Add general dummy stubs for MMD register access")
> 
> Please make sure to CC the author. Adding Kevin Hao <haokexin@...il.com>

The changes look fine to me, but the using of the "Fixes" tag seems a bit weird.
The "Fixes" tag is used to specify the commit causing regression instead of patch prerequisite.

Thanks,
Kevin


Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)