netdev - Re: [PATCH v4 net-next 08/15] net/sched: mqprio: allow offloading drivers to request queue count validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Feb 2023 15:08:38 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Vinicius Costa Gomes <vinicius.gomes@...el.com>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH v4 net-next 08/15] net/sched: mqprio: allow offloading
 drivers to request queue count validation

On Mon, Jan 30, 2023 at 07:31:38PM +0200, Vladimir Oltean wrote:
> mqprio_parse_opt() proudly has a comment:
> 
> 	/* If hardware offload is requested we will leave it to the device
> 	 * to either populate the queue counts itself or to validate the
> 	 * provided queue counts.
> 	 */
> 
> Unfortunately some device drivers did not get this memo, and don't
> validate the queue counts.
> 
> Introduce a tc capability, and make mqprio query it.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>