[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230201100454.61f32747@kernel.org>
Date: Wed, 1 Feb 2023 10:04:54 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jiri Pirko <jiri@...nulli.us>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
pabeni@...hat.com, edumazet@...gle.com, Tom Rix <trix@...hat.com>,
netdev@...r.kernel.org, richardcochran@...il.com,
vinicius.gomes@...el.com, Simon Horman <simon.horman@...igine.com>,
Sasha Neftin <sasha.neftin@...el.com>,
Naama Meir <naamax.meir@...ux.intel.com>
Subject: Re: [PATCH net 1/1] igc: return an error if the mac type is unknown
in igc_ptp_systim_to_hwtstamp()
On Wed, 1 Feb 2023 10:12:27 +0100 Jiri Pirko wrote:
> >@@ -652,7 +655,8 @@ static void igc_ptp_tx_hwtstamp(struct igc_adapter *adapter)
> >
> > regval = rd32(IGC_TXSTMPL);
> > regval |= (u64)rd32(IGC_TXSTMPH) << 32;
> >- igc_ptp_systim_to_hwtstamp(adapter, &shhwtstamps, regval);
> >+ if (igc_ptp_systim_to_hwtstamp(adapter, &shhwtstamps, regval))
>
> Use variable to store the return value.
Is that a rule.. IDK.. there's probably worse code in this driver 🤷️
The return value can't be propagated further anyway, since this is
a work.
Powered by blists - more mailing lists