netdev - Re: [PATCH ipsec-next v2] xfrm: fix bug with DSCP copy to v6 from v4 tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y9og7DV58e0KNPUB@gauss3.secunet.de>
Date:   Wed, 1 Feb 2023 09:21:00 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     Christian Hopps <chopps@...pps.org>,
        "David S. Miller" <davem@...emloft.net>, <devel@...ux-ipsec.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, <netdev@...r.kernel.org>,
        <chopps@...n.net>
Subject: Re: [PATCH ipsec-next v2] xfrm: fix bug with DSCP copy to v6 from v4
 tunnel

On Sat, Jan 28, 2023 at 09:42:26AM +0800, Herbert Xu wrote:
> On Thu, Jan 26, 2023 at 11:33:50AM -0500, Christian Hopps wrote:
> > When copying the DSCP bits for decap-dscp into IPv6 don't assume the
> > outer encap is always IPv6. Instead, as with the inner IPv4 case, copy
> > the DSCP bits from the correctly saved "tos" value in the control block.
> > 
> > Fixes: 227620e29509 ("[IPSEC]: Separate inner/outer mode processing on input")
> > 
> > Signed-off-by: Christian Hopps <chopps@...pps.org>
> > ---
> >  net/xfrm/xfrm_input.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Acked-by: Herbert Xu <herbert@...dor.apana.org.au>

I've applied the version with the 'Fixes' tag to the
ipsec tree, thanks everyone!