netdev - Re: [PATCH v5 net-next 00/13] add support for the the vsc7512 internal copper phys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Feb 2023 10:15:43 +0000
From:   Lee Jones <lee@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     patchwork-bot+netdevbpf@...nel.org,
        Colin Foster <colin.foster@...advantage.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux@...linux.org.uk,
        richardcochran@...il.com, f.fainelli@...il.com, andrew@...n.ch,
        UNGLinuxDriver@...rochip.com, alexandre.belloni@...tlin.com,
        claudiu.manoil@....com, vladimir.oltean@....com, pabeni@...hat.com,
        edumazet@...gle.com, davem@...emloft.net,
        krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org
Subject: Re: [PATCH v5 net-next 00/13] add support for the the vsc7512
 internal copper phys

On Tue, 31 Jan 2023, Jakub Kicinski wrote:

> On Tue, 31 Jan 2023 09:06:22 +0000 Lee Jones wrote:
> > Please don't do that.  The commits do not have proper Acked-by tags.
> > 
> > The plan is to merge these via MFD and send out a pull-request to an
> > immutable branch.  However, if you're prepared to convert all of the:
> > 
> >   Acked-for-MFD-by: Lee Jones <lee@...nel.org>
> > 
> > to
> > 
> >   Acked-by: Lee Jones <lee@...nel.org>
> 
> Sorry, I must have been blind yesterday because I definitely double
> checked this doesn't touch mfd code. And it does :/
> 
> The patches should not be sent for net-next if they are not supposed 
> to be applied directly. Or at the very least says something about
> merging in the cover letter!
> 
> > ... and send out a pull request to a succinct (only these patches) and
> > immutable branch then that is also an acceptable solution.
> > 
> > Please let me know what works best for you.
> 
> Sorry for messing up again. Stable branch would obviously had been best.
> Do we have to take action now, or can we just wait for the trees to
> converge during the merge window?

Russell explained to me (off-list) that the net-next branch is immutable
and the only way to fix this would be to revert the whole set.

Let's not go to that much trouble this time.

It does mean that I cannot take any more commits on the affected files,
but that shouldn't be a big deal seeing how far into the release cycle
we are.

No real harm done.

-- 
Lee Jones [李琼斯]