lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Feb 2023 11:24:19 +0100 From: Lorenzo Bianconi <lorenzo@...nel.org> To: bpf@...r.kernel.org Cc: netdev@...r.kernel.org, ast@...nel.org, daniel@...earbox.net, andrii@...nel.org, davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com, hawk@...nel.org, toke@...hat.com, memxor@...il.com, alardam@...il.com, saeedm@...dia.com, anthony.l.nguyen@...el.com, gospo@...adcom.com, vladimir.oltean@....com, nbd@....name, john@...ozen.org, leon@...nel.org, simon.horman@...igine.com, aelior@...vell.com, christophe.jaillet@...adoo.fr, ecree.xilinx@...il.com, mst@...hat.com, bjorn@...nel.org, magnus.karlsson@...el.com, maciej.fijalkowski@...el.com, intel-wired-lan@...ts.osuosl.org, lorenzo.bianconi@...hat.com, martin.lau@...ux.dev, sdf@...gle.com, gerhard@...leder-embedded.com Subject: [PATCH v5 bpf-next 3/8] xsk: add usage of XDP features flags From: Marek Majtyka <alardam@...il.com> Change necessary condition check for XSK from ndo functions to xdp features flags. Signed-off-by: Marek Majtyka <alardam@...il.com> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org> --- net/xdp/xsk_buff_pool.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/net/xdp/xsk_buff_pool.c b/net/xdp/xsk_buff_pool.c index ed6c71826d31..b2df1e0f8153 100644 --- a/net/xdp/xsk_buff_pool.c +++ b/net/xdp/xsk_buff_pool.c @@ -140,6 +140,10 @@ static void xp_disable_drv_zc(struct xsk_buff_pool *pool) } } +#define NETDEV_XDP_ACT_ZC (NETDEV_XDP_ACT_BASIC | \ + NETDEV_XDP_ACT_REDIRECT | \ + NETDEV_XDP_ACT_XSK_ZEROCOPY) + int xp_assign_dev(struct xsk_buff_pool *pool, struct net_device *netdev, u16 queue_id, u16 flags) { @@ -178,8 +182,7 @@ int xp_assign_dev(struct xsk_buff_pool *pool, /* For copy-mode, we are done. */ return 0; - if (!netdev->netdev_ops->ndo_bpf || - !netdev->netdev_ops->ndo_xsk_wakeup) { + if ((netdev->xdp_features & NETDEV_XDP_ACT_ZC) != NETDEV_XDP_ACT_ZC) { err = -EOPNOTSUPP; goto err_unreg_pool; } -- 2.39.1
Powered by blists - more mailing lists