netdev - Re: [PATCH net-next] r8169: use devm_clk_get_optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 02 Feb 2023 17:18:56 +0100
From:   John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     hkallweit1@...il.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, netdev@...r.kernel.org, nic_swsd@...ltek.com,
        pabeni@...hat.com, linux-sh@...r.kernel.org,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>
Subject: Re: [PATCH net-next] r8169: use devm_clk_get_optional_enabled() to
 simplify the code

Hi Geert!

On Thu, 2023-02-02 at 17:09 +0100, Geert Uytterhoeven wrote:
> > This change broke the r8169 driver on my SH7785LCR SuperH Evaluation Board.
> > 
> > With your patch, the driver initialization fails with:
> > 
> > [    1.648000] r8169 0000:00:00.0: error -EINVAL: failed to get ether_clk
> > [    1.676000] r8169: probe of 0000:00:00.0 failed with error -22
> > 
> > Any idea what could be the problem?
> 
> SH's clk_enable() returns -EINVAL if clk == NULL, which is wrong.
> Preparing a patch...

Ah, that explains the error message then.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913