[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y9ybPmWub43JpMUb@matsya>
Date: Fri, 3 Feb 2023 10:57:26 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Jonathan Corbet <corbet@....net>,
Madalin Bucur <madalin.bucur@....com>,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Horatiu Vultur <horatiu.vultur@...rochip.com>,
UNGLinuxDriver@...rochip.com,
Thierry Reding <thierry.reding@...il.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Rob Herring <robh@...nel.org>,
Krzysztof WilczyĆski <kw@...ux.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Kishon Vijay Abraham I <kishon@...nel.org>,
Alan Stern <stern@...land.harvard.edu>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Alim Akhtar <alim.akhtar@...sung.com>,
Siddharth Vadapalli <s-vadapalli@...com>,
Russell King <linux@...linux.org.uk>,
linux-phy@...ts.infradead.org, linux-doc@...r.kernel.org,
netdev@...r.kernel.org, linux-tegra@...r.kernel.org,
linux-pci@...r.kernel.org, linux-usb@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v2 6/9] net: ethernet: ti: am65-cpsw: Convert to
devm_of_phy_optional_get()
On 24-01-23, 19:37, Geert Uytterhoeven wrote:
> Use the new devm_of_phy_optional_get() helper instead of open-coding the
> same operation.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> v2:
> - Rebase on top of commit 854617f52ab42418 ("net: ethernet: ti:
> am65-cpsw: Handle -EPROBE_DEFER for Serdes PHY") in net-next
> (next-20230123 and later).
I was trying to apply this on rc1, so ofcourse this fails for me? How do
we resolve this?
I can skip this patch, provide a tag for this to be pulled into -net
tree
> ---
> drivers/net/ethernet/ti/am65-cpsw-nuss.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> index c696da89962f1ae3..794f228c8d632f7a 100644
> --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> @@ -1460,11 +1460,9 @@ static int am65_cpsw_init_serdes_phy(struct device *dev, struct device_node *por
> struct phy *phy;
> int ret;
>
> - phy = devm_of_phy_get(dev, port_np, name);
> - if (PTR_ERR(phy) == -ENODEV)
> - return 0;
> - if (IS_ERR(phy))
> - return PTR_ERR(phy);
> + phy = devm_of_phy_optional_get(dev, port_np, name);
> + if (IS_ERR_OR_NULL(phy))
> + return PTR_ERR_OR_ZERO(phy);
>
> /* Serdes PHY exists. Store it. */
> port->slave.serdes_phy = phy;
> --
> 2.34.1
--
~Vinod
Powered by blists - more mailing lists