netdev - Re: [PATCH net-next 2/2] net: enetc: add support for MAC Merge statistics counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230204170607.ldh7l5pnntz3cxc3@skbuf>
Date:   Sat, 4 Feb 2023 19:06:07 +0200
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Xiaoliang Yang <xiaoliang.yang_1@....com>
Subject: Re: [PATCH net-next 2/2] net: enetc: add support for MAC Merge
 statistics counters

On Sat, Feb 04, 2023 at 04:53:50PM +0200, Vladimir Oltean wrote:
> Add PF driver support for the following:
> 
> - Viewing the standardized MAC Merge layer counters.
> 
> - Viewing the standardized Ethernet MAC and RMON counters associated
>   with the pMAC.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---

I'm an absolute dumbass, I ran git format-patch without including this
uncommitted bit into the patch.

diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
index 631451d8f47c..4eb029364509 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
 /* Copyright 2017-2019 NXP */

+#include <linux/ethtool_netlink.h>
 #include <linux/net_tstamp.h>
 #include <linux/module.h>
 #include "enetc.h"

I'll resend on Monday. Other comments still welcome by then, of course.