[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230204001456.qf7xfmhyun7jqvbt@skbuf>
Date: Sat, 4 Feb 2023 02:14:56 +0200
From: Vladimir Oltean <olteanv@...il.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Woojung Huh <woojung.huh@...rochip.com>,
UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>,
Vivien Didelot <vivien.didelot@...il.com>,
Florian Fainelli <f.fainelli@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Wei Fang <wei.fang@....com>,
Heiner Kallweit <hkallweit1@...il.com>, kernel@...gutronix.de,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
Arun.Ramadoss@...rochip.com, intel-wired-lan@...ts.osuosl.org
Subject: Re: [PATCH net-next v4 01/23] net: dsa: microchip: enable EEE support
On Wed, Feb 01, 2023 at 03:58:23PM +0100, Oleksij Rempel wrote:
> +static int ksz_get_mac_eee(struct dsa_switch *ds, int port,
> + struct ethtool_eee *e)
> +{
> + int ret;
> +
> + ret = ksz_validate_eee(ds, port);
> + if (ret)
> + return ret;
> +
> + /* There is no documented control of Tx LPI configuration.
> + */
comment fits on a single line
> + e->tx_lpi_enabled = true;
> + /* There is no documented control of Tx LPI timer. According to testes
according to tests, I hope, not testes
> + * Tx LPI timer seems to be set by default to minimal value.
> + */
> + e->tx_lpi_timer = 0;
> +
> + return 0;
> +}
Powered by blists - more mailing lists