netdev - Re: [PATCH net-next 09/10] net: microchip: sparx5: initialize PSFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y95Ti6oI2gC7bA8Z@corigine.com>
Date:   Sat, 4 Feb 2023 13:46:03 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Daniel Machon <daniel.machon@...rochip.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, lars.povlsen@...rochip.com,
        Steen.Hegelund@...rochip.com, UNGLinuxDriver@...rochip.com,
        joe@...ches.com, richardcochran@...il.com, casper.casan@...il.com,
        horatiu.vultur@...rochip.com, shangxiaojing@...wei.com,
        rmk+kernel@...linux.org.uk, nhuck@...gle.com, error27@...il.com,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next 09/10] net: microchip: sparx5: initialize PSFP

On Thu, Feb 02, 2023 at 11:43:54AM +0100, Daniel Machon wrote:
> Initialize the SDLB's, stream gates and stream filters.
> 
> Signed-off-by: Daniel Machon <daniel.machon@...rochip.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>

> ---
>  .../ethernet/microchip/sparx5/sparx5_main.h    |  3 +++
>  .../ethernet/microchip/sparx5/sparx5_psfp.c    | 18 ++++++++++++++++++
>  .../net/ethernet/microchip/sparx5/sparx5_qos.c |  2 ++
>  3 files changed, 23 insertions(+)
> 
> diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_main.h b/drivers/net/ethernet/microchip/sparx5/sparx5_main.h
> index cffed893fb7b..72e7928912eb 100644
> --- a/drivers/net/ethernet/microchip/sparx5/sparx5_main.h
> +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_main.h
> @@ -456,6 +456,7 @@ int sparx5_sdlb_group_del(struct sparx5 *sparx5, u32 group, u32 idx);
>  
>  void sparx5_sdlb_group_init(struct sparx5 *sparx5, u64 max_rate, u32 min_burst,
>  			    u32 frame_size, u32 idx);
> +

nit: This hunk appears to belong in patch 4/9
     No need to respin because of this, afaic.

>  /* sparx5_police.c */
>  enum {
>  	/* More policer types will be added later */

...