netdev - Re: [PATCH v4 0/7] Add Ethernet driver for StarFive JH7110 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <958E7B1C-E0FF-416A-85AD-783682BA8B54@kernel.org>
Date:   Sat, 04 Feb 2023 15:22:20 +0100
From:   Conor Dooley <conor@...nel.org>
To:     yanhong wang <yanhong.wang@...rfivetech.com>
CC:     linux-riscv@...ts.infradead.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Emil Renner Berthing <kernel@...il.dk>,
        Richard Cochran <richardcochran@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Peter Geis <pgwipeout@...il.com>
Subject: Re: [PATCH v4 0/7] Add Ethernet driver for StarFive JH7110 SoC



On 3 February 2023 04:02:54 GMT+01:00, yanhong wang <yanhong.wang@...rfivetech.com> wrote:
>
>
>On 2023/1/19 7:21, Conor Dooley wrote:
>> Hey Yanhong!
>> 
>> On Wed, Jan 18, 2023 at 02:16:54PM +0800, Yanhong Wang wrote:
>>> This series adds ethernet support for the StarFive JH7110 RISC-V SoC. The series
>>> includes MAC driver. The MAC version is dwmac-5.20 (from Synopsys DesignWare).
>>> For more information and support, you can visit RVspace wiki[1].
>>> 	
>>> This patchset should be applied after the patchset [2], [3], [4].
>>> [1] https://wiki.rvspace.org/
>>> [2] https://lore.kernel.org/all/20221118010627.70576-1-hal.feng@starfivetech.com/
>>> [3] https://lore.kernel.org/all/20221118011108.70715-1-hal.feng@starfivetech.com/
>>> [4] https://lore.kernel.org/all/20221118011714.70877-1-hal.feng@starfivetech.com/
>> 
>> I've got those series applied, albeit locally, since they're not ready,
>> but I cannot get the Ethernet to work properly on my board.
>> I boot all of my dev boards w/ tftp, and the visionfive2 is no exception.
>> The fact that I am getting to the kernel in the first place means the
>> ethernet is working in the factory supplied U-Boot [1].
>> 
>> However, in Linux this ethernet port does not appear to work at all.
>> The other ethernet port is functional in Linux, but not in the factory
>> supplied U-Boot.
>> 
>> Is this a known issue? If it's not, I'll post the logs somewhere for
>> you. In case it is relevant, my board is a v1.2a.
>> 
>> Thanks,
>> Conor.
>> 
>> 1 - U-Boot 2021.10 (Oct 31 2022 - 12:11:37 +0800), Build: jenkins-VF2_515_Branch_SDK_Release-10
>
>
>No, this is not a issue. 
>These patches need to rely on the yt8531 phy driver of motorcomm company
>and the corresponding clock delay configuration to work normally, 
>and the yt8531 phy driver is being submitted. I have applied the
>motorcomm patchs during my test on board v1.2b, so the ethernet cannot work without
>the application of the motorcomm patchs. 
>
>For the patchs of yt8531, see [1]
>
>1 - https://patchwork.kernel.org/project/netdevbpf/cover/20230202030037.9075-1-Frank.Sae@motor-comm.com/

Please put that info into the cover of the next round of your submission then.

Thanks,
Conor.