netdev - Re: [PATCH v5 net-next 11/17] net/sched: taprio: centralize mqprio qopt validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230205122352.njikjy4da54gqmnx@skbuf>
Date:   Sun, 5 Feb 2023 14:23:52 +0200
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Gerhard Engleder <gerhard@...leder-embedded.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Vinicius Costa Gomes <vinicius.gomes@...el.com>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Simon Horman <simon.horman@...igine.com>
Subject: Re: [PATCH v5 net-next 11/17] net/sched: taprio: centralize mqprio
 qopt validation

On Sun, Feb 05, 2023 at 01:10:35PM +0100, Gerhard Engleder wrote:
> > +static bool intervals_overlap(int a, int b, int c, int d)
> 
> You may could keep the comment for this function.
> /* Returns true if the intervals [a, b) and [c, d) overlap. */
> 
> Reviewed-by: Gerhard Engleder <gerhard@...leder-embedded.com>

That was fixed in v6.
https://patchwork.kernel.org/project/netdevbpf/patch/20230204135307.1036988-8-vladimir.oltean@nxp.com/