lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 5 Feb 2023 15:55:17 +0200 From: Oz Shlomo <ozsh@...dia.com> To: <netdev@...r.kernel.org> CC: Saeed Mahameed <saeedm@...dia.com>, Roi Dayan <roid@...dia.com>, "Jiri Pirko" <jiri@...dia.com>, Marcelo Ricardo Leitner <mleitner@...hat.com>, "Simon Horman" <simon.horman@...igine.com>, Baowen Zheng <baowen.zheng@...igine.com>, Jamal Hadi Salim <jhs@...atatu.com>, Edward Cree <ecree.xilinx@...il.com>, "Oz Shlomo" <ozsh@...dia.com> Subject: [PATCH net-next v2 1/9] net/sched: optimize action stats api calls Currently the hw action stats update is called from tcf_exts_hw_stats_update, when a tc filter is dumped, and from tcf_action_copy_stats, when a hw action is dumped. However, the tcf_action_copy_stats is also called from tcf_action_dump. As such, the hw action stats update cb is called 3 times for every tc flower filter dump. Move the tc action hw stats update from tcf_action_copy_stats to tcf_dump_walker to update the hw action stats when tc action is dumped. Signed-off-by: Oz Shlomo <ozsh@...dia.com> Reviewed-by: Simon Horman <simon.horman@...igine.com> --- net/sched/act_api.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/sched/act_api.c b/net/sched/act_api.c index cd09ef49df22..f4fa6d7340f8 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -539,6 +539,8 @@ static int tcf_dump_walker(struct tcf_idrinfo *idrinfo, struct sk_buff *skb, (unsigned long)p->tcfa_tm.lastuse)) continue; + tcf_action_update_hw_stats(p); + nest = nla_nest_start_noflag(skb, n_i); if (!nest) { index--; @@ -1539,9 +1541,6 @@ int tcf_action_copy_stats(struct sk_buff *skb, struct tc_action *p, if (p == NULL) goto errout; - /* update hw stats for this action */ - tcf_action_update_hw_stats(p); - /* compat_mode being true specifies a call that is supposed * to add additional backward compatibility statistic TLVs. */ -- 1.8.3.1
Powered by blists - more mailing lists