netdev - Re: [PATCH net-next v3 0/3] tuntap: correctly initialize socket uid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167567881680.5476.3963142147251645490.git-patchwork-notify@kernel.org>
Date:   Mon, 06 Feb 2023 10:20:16 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Pietro Borrello <borrello@...g.uniroma1.it>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, lorenzo@...gle.com, stephen@...workplumber.org,
        c.giuffrida@...nl, h.j.bos@...nl, jkl820.git@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 0/3] tuntap: correctly initialize socket uid

Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@...emloft.net>:

On Sat, 04 Feb 2023 17:39:19 +0000 you wrote:
> sock_init_data() assumes that the `struct socket` passed in input is
> contained in a `struct socket_alloc` allocated with sock_alloc().
> However, tap_open() and tun_chr_open() pass a `struct socket` embedded
> in a `struct tap_queue` and `struct tun_file` respectively, both
> allocated with sk_alloc().
> This causes a type confusion when issuing a container_of() with
> SOCK_INODE() in sock_init_data() which results in assigning a wrong
> sk_uid to the `struct sock` in input.
> 
> [...]

Here is the summary with links:
  - [net-next,v3,1/3] net: add sock_init_data_uid()
    https://git.kernel.org/netdev/net-next/c/584f3742890e
  - [net-next,v3,2/3] tun: tun_chr_open(): correctly initialize socket uid
    https://git.kernel.org/netdev/net-next/c/a096ccca6e50
  - [net-next,v3,3/3] tap: tap_open(): correctly initialize socket uid
    https://git.kernel.org/netdev/net-next/c/66b2c338adce

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html