netdev - Re: [PATCH net-next] net: lan966x: Add support for TC flower filter statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y+DZe7uglZqNWu+b@corigine.com>
Date:   Mon, 6 Feb 2023 11:42:03 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next] net: lan966x: Add support for TC flower filter
 statistics

On Mon, Feb 06, 2023 at 11:32:52AM +0100, Horatiu Vultur wrote:
> The 02/06/2023 10:59, Simon Horman wrote:
> > 
> > > > Also, not strictly related, but could you consider, as a favour to
> > > > reviewers, fixing the driver so that the following doesn't fail:
> > > >
> > > > $ make drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
> > > >   DESCEND objtool
> > > >   CALL    scripts/checksyscalls.sh
> > > >   CC      drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
> > > > In file included from drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c:3:
> > > > drivers/net/ethernet/microchip/lan966x/lan966x_main.h:18:10: fatal error: vcap_api.h: No such file or directory
> > > >    18 | #include <vcap_api.h>
> > > >       |          ^~~~~~~~~~~~
> > > > compilation terminated.
> > >
> > > I will try to have a look at this.
> > 
> > Thanks, much appreciated.
> 
> Sorry for coming back to this, but it seems that I can't reproduce the
> issue:
> 
> $ make drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
>   CALL    scripts/checksyscalls.sh
>   DESCEND objtool
>   CC      drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
> 
> I have tried different configurations without any luck. Any suggestion
> on how to reproduce the issue?

Sorry, perhaps it is something on my side.

I tried running through the steps below, which is what I assume
I had done last time, but I don't see the problem any more.

I'll let you know if it shows up again.
But in the meantime sorry for the false reporting.

$ git checkout net-next/main
$ make allmodconfig
$ make prepare
$ make drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o