[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <f769cbc4-0d13-d951-9a6d-ff792300a1aa@nvidia.com>
Date: Mon, 6 Feb 2023 15:10:02 +0200
From: Roi Dayan <roid@...dia.com>
To: Simon Horman <simon.horman@...igine.com>,
Oz Shlomo <ozsh@...dia.com>
Cc: netdev@...r.kernel.org, Saeed Mahameed <saeedm@...dia.com>,
Jiri Pirko <jiri@...dia.com>,
Marcelo Ricardo Leitner <mleitner@...hat.com>,
Baowen Zheng <baowen.zheng@...igine.com>,
Jamal Hadi Salim <jhs@...atatu.com>,
Edward Cree <ecree.xilinx@...il.com>
Subject: Re: [PATCH net-next v2 9/9] net/sched: TC, support per action stats
On 06/02/2023 13:03, Simon Horman wrote:
> On Sun, Feb 05, 2023 at 03:55:25PM +0200, Oz Shlomo wrote:
>> Extend the action stats callback implementation to update stats for actions
>> that are associated with hw counters.
>> Note that the callback may be called from tc action utility or from tc
>> flower. Both apis expect the driver to return the stats difference from
>> the last update. As such, query the raw counter value and maintain
>> the diff from the last api call in the tc layer, instead of the fs_core
>> layer.
>>
>> Signed-off-by: Oz Shlomo <ozsh@...dia.com>
>> Reviewed-by: Roi Dayan <roid@...dia.com>
>
> nit: I think the prefix for this patch should be 'net/mlx5e'
it should. missed it i guess. also prev patch 8/9 ".. TC, support per action stats".
thanks
>
>> ---
>> .../net/ethernet/mellanox/mlx5/core/en/rep/tc.c | 2 +-
>> .../ethernet/mellanox/mlx5/core/en/tc/act_stats.c | 44 ++++++++++++++++++++++
>> .../ethernet/mellanox/mlx5/core/en/tc/act_stats.h | 4 ++
>> .../net/ethernet/mellanox/mlx5/core/en/tc_priv.h | 1 +
>> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 39 +++++++++++++------
>> drivers/net/ethernet/mellanox/mlx5/core/en_tc.h | 2 +
>> .../net/ethernet/mellanox/mlx5/core/fs_counters.c | 10 +++++
>> include/linux/mlx5/fs.h | 2 +
>> 8 files changed, 91 insertions(+), 13 deletions(-)
>
> ...
Powered by blists - more mailing lists