[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <86b7936aa6c306c61a782950c762fe3124229c51.camel@gmail.com>
Date: Mon, 06 Feb 2023 07:40:43 -0800
From: Alexander H Duyck <alexander.duyck@...il.com>
To: Paul Blakey <paulb@...dia.com>, netdev@...r.kernel.org,
Saeed Mahameed <saeedm@...dia.com>,
Paolo Abeni <pabeni@...hat.com>,
Jakub Kicinski <kuba@...nel.org>,
Eric Dumazet <edumazet@...gle.com>,
Jamal Hadi Salim <jhs@...atatu.com>,
Cong Wang <xiyou.wangcong@...il.com>,
"David S. Miller" <davem@...emloft.net>
Cc: Oz Shlomo <ozsh@...dia.com>, Jiri Pirko <jiri@...dia.com>,
Roi Dayan <roid@...dia.com>, Vlad Buslov <vladbu@...dia.com>
Subject: Re: [PATCH net-next v8 4/7] net/mlx5: Kconfig: Make tc offload
depend on tc skb extension
On Sun, 2023-02-05 at 17:49 +0200, Paul Blakey wrote:
> Tc skb extension is a basic requirement for using tc
> offload to support correct restoration on action miss.
>
> Depend on it.
>
> Signed-off-by: Paul Blakey <paulb@...dia.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 2 +-
> drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c | 2 --
> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 --
> 3 files changed, 1 insertion(+), 5 deletions(-)
>
So one question I had is what about the use of the SKB_EXT check in
mlx5/core/en_tc.h? Seems like you could remove that one as well since
it is wrapped in a check for MLX5_CLS_ACT before the check for
NET_TC_SKB_EXT.
Powered by blists - more mailing lists