netdev - Re: [PATCH net-next v8 4/7] net/mlx5: Kconfig: Make tc offload depend on tc skb extension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Feb 2023 19:16:55 +0200
From:   Paul Blakey <paulb@...dia.com>
To:     Alexander H Duyck <alexander.duyck@...il.com>,
        netdev@...r.kernel.org, Saeed Mahameed <saeedm@...dia.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     Oz Shlomo <ozsh@...dia.com>, Jiri Pirko <jiri@...dia.com>,
        Roi Dayan <roid@...dia.com>, Vlad Buslov <vladbu@...dia.com>
Subject: Re: [PATCH net-next v8 4/7] net/mlx5: Kconfig: Make tc offload depend
 on tc skb extension



On 06/02/2023 17:40, Alexander H Duyck wrote:
> On Sun, 2023-02-05 at 17:49 +0200, Paul Blakey wrote:
>> Tc skb extension is a basic requirement for using tc
>> offload to support correct restoration on action miss.
>>
>> Depend on it.
>>
>> Signed-off-by: Paul Blakey <paulb@...dia.com>
>> ---
>>   drivers/net/ethernet/mellanox/mlx5/core/Kconfig     | 2 +-
>>   drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c | 2 --
>>   drivers/net/ethernet/mellanox/mlx5/core/en_tc.c     | 2 --
>>   3 files changed, 1 insertion(+), 5 deletions(-)
>>
> 
> So one question I had is what about the use of the SKB_EXT check in
> mlx5/core/en_tc.h? Seems like you could remove that one as well since
> it is wrapped in a check for MLX5_CLS_ACT before the check for
> NET_TC_SKB_EXT.


Good catch, ill remove it.

Thanks.