netdev - Re: [PATCH net-next 4/4] ionic: page cache for rx buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2cf1ed45-a2ff-b351-6594-01fb8fb9bd3b@amd.com>
Date:   Mon, 6 Feb 2023 09:25:24 -0800
From:   Shannon Nelson <shannon.nelson@....com>
To:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, drivers@...sando.io,
        Neel Patel <neel.patel@....com>
Subject: Re: [PATCH net-next 4/4] ionic: page cache for rx buffers

On 2/4/23 3:09 AM, Maciej Fijalkowski wrote:
> On Fri, Feb 03, 2023 at 08:28:53PM -0800, Jakub Kicinski wrote:
>> On Fri, 3 Feb 2023 13:00:16 -0800 Shannon Nelson wrote:
>>> From: Neel Patel <neel.patel@....com>
>>>
>>> Use a local page cache to optimize page allocation & dma mapping.
>>
>> Please use the page_pool API rather than creating your own caches.
> 
> +1, please also add perf numbers on next revision

Thanks Jakub and Maciej for the comments.  For now I'll drop this patch 
and post a v2, and work with Neel to see what we can do with the Rx 
buffer pool patch in the longer term.

sln