[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d31bd1b26b07bd316b0adea3aa897c4623268304.camel@redhat.com>
Date: Mon, 06 Feb 2023 19:16:39 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Eric Dumazet <edumazet@...gle.com>,
"David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com,
Alexander Duyck <alexanderduyck@...com>,
Soheil Hassas Yeganeh <soheil@...gle.com>
Subject: Re: [PATCH net-next 0/4] net: core: use a dedicated kmem_cache for
skb head allocs
On Thu, 2023-02-02 at 18:57 +0000, Eric Dumazet wrote:
> Our profile data show that using kmalloc(non_const_size)/kfree(ptr)
> has a certain cost, because kfree(ptr) has to pull a 'struct page'
> in cpu caches.
>
> Using a dedicated kmem_cache for TCP skb->head allocations makes
> a difference, both in cpu cycles and memory savings.
>
> This kmem_cache could also be used for GRO skb allocations,
> this is left as a future exercise.
>
> Eric Dumazet (4):
> net: add SKB_HEAD_ALIGN() helper
> net: remove osize variable in __alloc_skb()
> net: factorize code in kmalloc_reserve()
> net: add dedicated kmem_cache for typical/small skb->head
>
> include/linux/skbuff.h | 8 ++++
> net/core/skbuff.c | 95 +++++++++++++++++++++++++++---------------
> 2 files changed, 70 insertions(+), 33 deletions(-)
LGTM,
Acked-by: Paolo Abeni <pabeni@...hat.com>
Thanks!
Paolo
Powered by blists - more mailing lists